Fix output routing when threads inherit context - #1559
Open
emecii wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1491
A background thread can inherit the executing cell's
ContextVarstate (the default on free-threaded CPython, and also possible withcopy_context). Because ipykernel treated any context-local parent as belonging to the current thread, a persistent worker stayed pinned to the cell that created it.Store the setting thread ID with each context-local parent, and fall back to the current global parent when another thread observes an inherited context. Explicit
set_parentandset_thread_parentcalls in the worker still pin output as before.The regression runs a worker in a copied context and covers both stream and display output across three cells, including explicit global and temporary thread-local overrides.
🤖🤖 AI-assisted contribution.